Bug 2105003: on-prem: improvements on resolv-prepender #3271
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
jcaamano
force-pushed
the
wait-resolv-conf
branch
6 times, most recently
from
da83d68 to
57daeab
Compare
|
/test ? |
|
@jcaamano: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-ipi-ovn-dualstack |
1 similar comment
|
/test e2e-metal-ipi-ovn-dualstack |
jcaamano
force-pushed
the
wait-resolv-conf
branch
from
57daeab to
4eb8982
Compare
|
/test e2e-metal-ipi-ovn-dualstack |
|
/test e2e-metal-ipi-ovn-dualstack |
1 similar comment
|
/test e2e-metal-ipi-ovn-dualstack |
jcaamano
force-pushed
the
wait-resolv-conf
branch
2 times, most recently
from
066a2fb to
3fa18a3
Compare
|
/test e2e-metal-ipi-ovn-dualstack |
jcaamano
force-pushed
the
wait-resolv-conf
branch
from
3fa18a3 to
38b0231
Compare
|
/test e2e-metal-ipi-ovn-dualstack |
1 similar comment
|
/test e2e-metal-ipi-ovn-dualstack |
|
/test e2e-metal-ipi-ovn-ipv6 |
Currently a NetworkManager dispatcher script does not have the correct selinux permission to dbus chat with hostnamed. Work around the issue using systemd-run. See: https://bugzilla.redhat.com/show_bug.cgi?id=2111632 Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
If resolve prepender takes more than NetworkManager timeout, currently 90s, it might fail to bring up devices before we had a chance to process all possible events for a device. This needs to account for different type of events and IPv4 and IPv6 events in case of dual stack and overall take less then the NetworkManager timeout. Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
node-ip can fail if a device is not ready to be bound to. Retry but don't add to the overall timeout more than the NetworkManager timeout (90s) accounting for all the events we need to attend to. Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
Make resolv-prepender wait for nameservers in /run/NetworkManager/resolv.conf in all cases to avoid copying it without them to /etc/resolv.conf Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
Without a properly configured resolv.conf, openshift-dns coredns will fail to run. These pods have a default DNS policy and will use the host resolv.conf, which is the one kubelet gets when it starts. Signed-off-by: Jaime Caamaño Ruiz <[email protected]>
openshift-ci
bot
added
bugzilla/severity-high
|
@jcaamano: This pull request references Bugzilla bug 2105003, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-metal-ipi |
|
@jcaamano: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm This looks awesome, thanks! |
|
@jcaamano: This pull request references Bugzilla bug 2105003, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @sinnykumari |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron, jcaamano, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jcaamano: All pull requests linked via external trackers have merged: Bugzilla bug 2105003 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@mandre: new pull request created: #3287 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In order to avoid a podman issue [1] causing a layer corruption when an image pull is killed midway, let's move the image pull outside of the timeout command. The timeout was recently reduced to 20 seconds with [2] making the issue more likely to happen. [1] containers/podman#14003 [2] openshift#3271
In order to avoid a podman issue [1] causing a layer corruption when an image pull is killed midway, let's move the image pull outside of the timeout command. The timeout was recently reduced to 20 seconds with [2] making the issue more likely to happen. [1] containers/podman#14003 [2] openshift#3271
Work around several resolv-prepender issues: